Skip to content
This repository was archived by the owner on Mar 4, 2025. It is now read-only.

fixes #906 infinite scolling for user challenges #962

Merged
merged 4 commits into from
Jan 30, 2017

Conversation

shubhendusaurabh
Copy link
Contributor

fixes #906 infinite scolling for user challenges

@birdofpreyru
Copy link
Collaborator

@shubhendusaurabh Hey, I wonder, whether have you managed to locally run the App against the production database, or have you come with other ideas how to test it? It turns out to be a bit trickier, than I expected.

@shubhendusaurabh
Copy link
Contributor Author

shubhendusaurabh commented Jan 28, 2017

@birdofpreyru What I did was to change API_URL and API_URL_V2 to production URLs directly in appirio-tech-webpack-config module. So for auth dev API was used and for the profile, production API was used. And for my-challenges, replaced vm.handle with my handle in my-challenges controller.

I also spent more time figuring out how to run the app with production API rather than fixing the issue. 😫

@birdofpreyru
Copy link
Collaborator

@shubhendusaurabh Hey, sorry for a delay with reviewing your submission.

On the /my-challenges route it works just perfect.

On the /members/HANDLE/details/?track=... it still shows and demands to click the LOAD MORE button the first time you I scroll down the list. After I click it, it works perfect (when I scroll to the new end of the list, no need for clicking anything again). Thus, I just want to ask you a small change: please, remove this LOAD MORE button, so that the page /members/HANDLE/details/?track=... works the same as the /my-challenge one: just an infinite scrolling from the very beginning.

Also, as I see it working fine, let's increase the CHALLENGES_LOADING_CHUNK to 36

@shubhendusaurabh
Copy link
Contributor Author

@birdofpreyru updated

@birdofpreyru birdofpreyru merged commit 688a6b7 into topcoder-archive:dev Jan 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[$60] - Replace "Load More" with infinite scroll
3 participants